Adds GRPCIO guards on tfserving-proxy server to fix version clash #2788
Conversation
|
/test integration |
|
Thu Dec 17 07:49:55 UTC 2020 impatient try |
|
Thu Dec 17 07:50:05 UTC 2020 impatient try |
|
Thu Dec 17 07:50:13 UTC 2020 impatient try |
| @@ -1,3 +1,5 @@ | |||
| tensorflow>=1.12.0 | |||
| tensorflow-serving-api>=1.10.1 | |||
| grpcio==1.32.0 # Required for https://github.com/SeldonIO/seldon-core/issues/2787 | |||
There was a problem hiding this comment.
Any link to the tensorflow issue that this fixes? Maybe add to seldon-core issue.
There was a problem hiding this comment.
It's not really an issue, it's just that they have a hard requirement for grpcio==0.32.0, whereas seldon-core package installs 1.34.0 on the base redhat image
There was a problem hiding this comment.
So why not fix python package to 1.32.0 ?
There was a problem hiding this comment.
Ok actually I've added tensorflow/tensorflow#45785 to see if they can actually update it, but let's see, I do expect them to just say "we'll need to stick with 1.32.x" for Y reasons
|
Thu Dec 17 08:50:19 UTC 2020 impatient try |
|
Thu Dec 17 08:50:28 UTC 2020 impatient try |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #2787
This will also have to be cherry-picked for 1.5.1 release.