-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alibi Detect Server #2832
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Tue Jan 12 13:33:15 UTC 2021 impatient try |
Tue Jan 12 13:33:17 UTC 2021 impatient try |
/test integration |
Tue Jan 12 13:57:28 UTC 2021 impatient try |
@@ -5,6 +5,7 @@ class Protocol(Enum): | |||
tensorflow_http = "tensorflow.http" | |||
seldon_http = "seldon.http" | |||
seldonfeedback_http = "seldonfeedback.http" | |||
v2_http = "v2.http" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for consistency do you want to call it v2.http instead of kfserving? Conscious that this is kfserving in executor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
All looks good! Once protocol updated should be good to merge 👍 |
Hmm I've seen this issue in another pr |
Tue Jan 12 17:22:22 UTC 2021 impatient try |
Tue Jan 12 17:23:52 UTC 2021 impatient try |
Tue Jan 12 17:37:18 UTC 2021 impatient try |
Tue Jan 12 17:37:35 UTC 2021 impatient try |
/test integration |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tue Jan 12 20:35:57 UTC 2021 impatient try |
Tue Jan 12 22:17:42 UTC 2021 impatient try |
Tue Jan 12 22:18:13 UTC 2021 impatient try |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2831
Special notes for your reviewer:
Does this PR introduce a user-facing change?: