Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alibi Detect Server #2832

Merged
merged 5 commits into from
Jan 12, 2021
Merged

Update Alibi Detect Server #2832

merged 5 commits into from
Jan 12, 2021

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Jan 12, 2021

What this PR does / why we need it:

  • Update Alibi Detect Server to use Alibi 0.4.4.
    • This allows usage of more complex drift models that have a preprocessor model. These can be saved and loaded as expected.
  • Update Alibi detect server to support V2 dataplane
    • This allows use of Triton inference server

Which issue(s) this PR fixes:

Fixes #2831

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

Tue Jan 12 13:33:15 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2832/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2832 --build=1

@seldondev
Copy link
Collaborator

Tue Jan 12 13:33:17 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2832/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2832 --build=2

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jan 12 13:57:28 UTC 2021
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2832/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2832 --build=3

@@ -5,6 +5,7 @@ class Protocol(Enum):
tensorflow_http = "tensorflow.http"
seldon_http = "seldon.http"
seldonfeedback_http = "seldonfeedback.http"
v2_http = "v2.http"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency do you want to call it v2.http instead of kfserving? Conscious that this is kfserving in executor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@axsaucedo
Copy link
Contributor

All looks good! Once protocol updated should be good to merge 👍

@axsaucedo
Copy link
Contributor

Hmm I've seen this issue in another pr ERROR: Could not find a version that satisfies the requirement pandas==1.2.0, it seems to be a dev dependency, so probably the integration tests weren't run when I merged it. We should probably revert #2804.

@seldondev
Copy link
Collaborator

Tue Jan 12 17:22:22 UTC 2021
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2832/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2832 --build=5

@seldondev
Copy link
Collaborator

Tue Jan 12 17:23:52 UTC 2021
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2832/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2832 --build=4

@seldondev
Copy link
Collaborator

Tue Jan 12 17:37:18 UTC 2021
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2832/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2832 --build=6

@seldondev
Copy link
Collaborator

Tue Jan 12 17:37:35 UTC 2021
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2832/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2832 --build=7

@axsaucedo
Copy link
Contributor

/test integration
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Jan 12 20:35:57 UTC 2021
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2832/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2832 --build=8

@seldondev
Copy link
Collaborator

Tue Jan 12 22:17:42 UTC 2021
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2832/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2832 --build=9

@seldondev
Copy link
Collaborator

Tue Jan 12 22:18:13 UTC 2021
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2832/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2832 --build=10

@seldondev seldondev merged commit 0dce206 into SeldonIO:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support V2 Protocol in outlier and drift detectors
3 participants