Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving basic CI to github actions #2889

Merged
merged 6 commits into from
Jan 26, 2021
Merged

Conversation

axsaucedo
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

  • Moves unit tests and lint into github actions

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Jan 26 18:21:14 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2889/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2889 --build=2

@seldondev
Copy link
Collaborator

Tue Jan 26 18:21:10 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2889/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2889 --build=1

@axsaucedo
Copy link
Contributor Author

Lint and pr-build would not run successfully given they are being removed in favour of the github actions tests

@axsaucedo
Copy link
Contributor Author

Merging PR as it's required in order to run gh actions, all tests pass locally running with https://github.com/nektos/act

@axsaucedo axsaucedo merged commit 964f621 into SeldonIO:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants