Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PIP in base image to align with Python Cryptography Framework version #2974

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

axsaucedo
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Follow up fix from #2970 to ensure all python derivative images build as the pip package is not compatible with the newer version of the cryptography library. This also includes an update on the UPGRADING.md page.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@axsaucedo
Copy link
Contributor Author

/test release

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor Author

/test release

@seldondev
Copy link
Collaborator

@axsaucedo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
release-build-push f62c45c link /test release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor Author

Build and push script runs successfully - merging

@axsaucedo axsaucedo merged commit 034d2ed into SeldonIO:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants