Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notes on Go module tags in release docs #4595

Merged
merged 17 commits into from
Jan 18, 2023
Merged

Add notes on Go module tags in release docs #4595

merged 17 commits into from
Jan 18, 2023

Conversation

agrski
Copy link
Contributor

@agrski agrski commented Jan 17, 2023

What this PR does / why we need it:
This PR does two things:

  • First, and foremost, it explains the need for multiple tags for every release.
  • Secondly, and incidentally, it provides a number of minor grammatical and formatting changes in the release docs.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@agrski agrski marked this pull request as draft January 17, 2023 17:42
RafalSkolasinski
RafalSkolasinski approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrski
Add instructions on creating & pushing the Go module tags
9f5cb18
@agrski
Update sed script for extracting module subdir paths for tags
15eba80
@agrski
Use consistent capitalisation for v2 in SCv2
7326c55
@agrski
Improve wording in release docs intro for flow
0072b4e
@agrski
Fix typo + use consistent, imperative style for process summary
d00dd55
@agrski
Add step for Go module tags in release process summary
5c9ee7a
@agrski
Improve wording by removing duplication of the subject in the conditi…
dd6daa2 
…onal clause
@agrski
Grammar + formatting for consistency
2ad3ad4
@agrski
Formatting for clarity
33874e9
@agrski
Reword link text to indicate third party docs
f37bf52
@agrski
Replace module subdir extraction commands with single find command
23e2471
@agrski
Remove unnecessary version suffixes for module listing
0ac5d13
@agrski
Add missing dashes to treat value as an option in example command
f0d09e9
@agrski
Reword sentence
0992eb0
@agrski agrski marked this pull request as ready for review January 17, 2023 18:44
RafalSkolasinski
RafalSkolasinski approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrski agrski changed the title Add notes on release tags in docs Add notes on Go module tags in release docs Jan 18, 2023
@agrski agrski merged commit c9787cf into SeldonIO:v2 Jan 18, 2023
@agrski agrski deleted the add-notes-on-release-tags-in-docs branch January 18, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalSkolasinski RafalSkolasinski RafalSkolasinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agrski @RafalSkolasinski