Use a more recent jdk base image #4815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrski
reviewed
Apr 24, 2023
| @@ -14,7 +14,7 @@ RUN gradle build --no-daemon --info | |||
| ################################################################################ | |||
|
|
|||
| # Some dependencies require glibc, which Alpine does not provide | |||
| FROM registry.access.redhat.com/ubi9/openjdk-17-runtime:1.14-2 | |||
| FROM registry.access.redhat.com/ubi9/openjdk-17-runtime:1.14-2.1681917142 | |||
There was a problem hiding this comment.
❓ Would latest be preferable to the specific version?
There was a problem hiding this comment.
We have not concluded yet whether it is alright to use latest tag. So bumping up the version for now.
There was a problem hiding this comment.
Shouldn't rebuild with 1.14-2 (if it is a rolling tag) basically include the latest version of it, in this example 1.14-2.1681917142?
There was a problem hiding this comment.
1.14-2 is not a rolling tag (1.14 is).
There was a problem hiding this comment.
I'd probably stick to 1.14 then same way as I'd use for base ubuntu:22.04 and not specific build of it - but you are right we did not make specific decision on these yet.
agrski
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update
dataflow-enginebase jdk image to use a more recent one to sort out CVEs.At the time of writing:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: