Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

484 metrics port #485

Merged
merged 4 commits into from
Apr 9, 2019
Merged

484 metrics port #485

merged 4 commits into from
Apr 9, 2019

Conversation

ryandawsonuk
Copy link
Contributor

@ryandawsonuk ryandawsonuk commented Apr 3, 2019

fixes #484

Checked this by adding parameters to helm install for seldon-core - --set engine.port=14040 --set engine.grpc.port=14041 --set engine.prometheus.path="micrometheus". Then installed a model and was able to validate that the pod spec contained:

kind: Pod
metadata:
  annotations:
    prometheus.io/path: /micrometheus
    prometheus.io/port: "14040"
    prometheus.io/scrape: "true"
...
    - name: ENGINE_SERVER_PORT
      value: "14040"
    - name: ENGINE_SERVER_GRPC_PORT
      value: "14041"
...
   ports:
    - containerPort: 14040
      protocol: TCP
    - containerPort: 14041
      name: grpc
      protocol: TCP

Also ran the E2E tests

Copy link
Contributor

@ukclivecox ukclivecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This will effect the AWS marketplace release as the Helm chart has changed.

@ukclivecox ukclivecox merged commit fd15032 into master Apr 9, 2019
@ryandawsonuk ryandawsonuk deleted the 484-metrics-port branch April 9, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure the way Prometheus exposed
3 participants