Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(k6): add support for k8s loading/unloading of Seldon CRs #5563

Merged
merged 6 commits into from
May 7, 2024

Commits on May 2, 2024

  1. feat(k6): add support for k8s loading/unloading of Seldon CRs

    This adds initial support for k8s via the `USE_KUBE_CONTROL_PLANE` environment
    variable:
    
    - models/pipelines/experiments in components/model.js are modified to also
    return CR yamls
    - updates functions in components/utils.js (including `setupBase(...)` and
    `teardownBase(...)` to use xk6-kubernetes, when configured
    - all scenarios already using `setupBase(...)` should work unchanged
    
    **Which issue(s) this PR fixes:**
    - INFRA-949 (internal issue) Extend existing k6 scenarios to use xk6-kubernetes
    
    - [ ] Test functionality in kind
    - [ ] Extend existing k6 scenarios to use xk6-kubernetes
    lc525 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    52ab9b5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    05ab4d8 View commit details
    Browse the repository at this point in the history
  3. fixes after testing in kind

    - works: model creation + load
    - fails: getting model status via k8s (permissions)
    - fails: deleting/tear down models (permissions)
    lc525 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2211aa1 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    b505b7e View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. fixes following review comments

    - cleanup commented debug calls
    - remove minReplicas from CRs
    lc525 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bb5fd35 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a49a16c View commit details
    Browse the repository at this point in the history