Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(grpc): move to latest versions of protobuf/grpc codegen tools #5789

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

lc525
Copy link
Member

@lc525 lc525 commented Jul 22, 2024

This updates the version for protobuf/grpc codegen tools as follows:

  • protoc 21.10 -> 27.2
  • protoc-gen-go plugin 1.28.1 -> 1.34.2
  • protoc-gen-go-grpc plugin 1.2.0 -> 1.4.0
  • protoc-gen-kotlin-grpc plugin 1.2.1 -> 1.4.1
  • protoc-gen-java-grpc plugin 1.45.1 -> 1.65.1
  • python grpcio-tools 1.51.3 -> 1.64.1

The python grpcio-tools was not updated to the latest available version (1.65.1) because of
persisting issues with logs being spammed in that release.

Tests
The following tests were executed in order to guarantee that this update doesn't introduce
problematic behaviour:

  • control-plane and data-plane load tests (k6)
  • pipeline smoke tests
  • cluster update from 2.8.2
  • cluster update from 2.8.3

Which issue(s) this PR fixes:
Fixes #INFRA-1076

Special notes for your reviewer:

@lc525 lc525 requested a review from sakoush as a code owner July 22, 2024 16:24
@lc525 lc525 added the v2 label Jul 22, 2024
@lc525 lc525 changed the title build(grpc) move to latest versions of protobuf/grpc codegen tools build(grpc): move to latest versions of protobuf/grpc codegen tools Jul 22, 2024
implementation("io.kubernetes:client-java:20.0.1") {
exclude("com.microsoft.azure", "adal4j")
}
implementation("io.kubernetes:client-java:21.0.0")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, io.kubernetes:client-java:21.0.0 depends on the newer grpc libraries, and also allows us to remove the previous constraints applied to its dependencies (commons-compress) because the CVEs have been fixed in the new version.

implementation("com.google.protobuf:protobuf-java") {
version {
strictly("[4.27.2,)")
prefer("4.27.2")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, the major version "4" is java-specific, while {minor}.{patch} reference the protobuf version (27.2).

- the code generated for protobuf messages and grpc services
@lc525 lc525 force-pushed the INFRA-1076/protobuf-codegen-updates-2 branch from 51e37a5 to 6c4eb71 Compare July 23, 2024 11:04
@lc525 lc525 merged commit 641928a into SeldonIO:v2 Jul 23, 2024
3 checks passed
@lc525 lc525 deleted the INFRA-1076/protobuf-codegen-updates-2 branch July 23, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants