Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry Image Tags and RBAC control for Operator Helm Chart #624

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Registry Image Tags and RBAC control for Operator Helm Chart #624

merged 2 commits into from
Jun 13, 2019

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Jun 8, 2019 •
edited
Loading

  • RBAC Controls and Service Account name needed for GCP marketplace

@seldondev seldondev added size/L and removed size/S labels Jun 13, 2019
@ryandawsonuk
Copy link
Contributor

Do we need to separate out 'registry'? I'm used to that being included in the image.repository - https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md#configuration

@ryandawsonuk
Copy link
Contributor

Comparing https://github.com/helm/charts/search?l=Markdown&q=%22image.registry%22 to https://github.com/helm/charts/search?l=Markdown&q=%22image.repository%22 it seems there is no clear standard

@ryandawsonuk ryandawsonuk merged commit dfbf57a into SeldonIO:master Jun 13, 2019
@ukclivecox ukclivecox deleted the gcp_marketplace branch February 14, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandawsonuk ryandawsonuk Awaiting requested review from ryandawsonuk

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ukclivecox @ryandawsonuk @seldondev