Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metrics and fixed docs typos #763

Merged
merged 1 commit into from
Aug 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"\n",
"5) Test the predictions as well as explanations\n",
"\n",
"# Before you start\n",
"## Before you start\n",
"Make sure you install the following dependencies, as they are critical for this example to work:\n",
"\n",
"* Helm v2.13.1+\n",
Expand Down
2 changes: 1 addition & 1 deletion examples/kubeflow/kubeflow_seldon_e2e_pipeline.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@
}
],
"source": [
"!helm install seldon-core-operator --namespace kubeflow --repo https://storage.googleapis.com/seldon-charts"
"!helm install seldon-core-operator --namespace kubeflow --repo https://storage.googleapis.com/seldon-charts --set usageMetrics.enabled=true "
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@
}
],
"source": [
"!helm install seldon-core-operator --name seldon-core-operator --repo https://storage.googleapis.com/seldon-charts\n",
"!helm install seldon-core-operator --name seldon-core-operator --repo https://storage.googleapis.com/seldon-charts --set usageMetrics.enabled=true\n",
"!kubectl rollout status statefulset.apps/seldon-operator-controller-manager "
]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@
}
],
"source": [
"!helm install seldon-core-operator --name seldon-core-operator --repo https://storage.googleapis.com/seldon-charts"
"!helm install seldon-core-operator --name seldon-core-operator --repo https://storage.googleapis.com/seldon-charts --set usageMetrics.enabled=true"
]
},
{
Expand Down