Create Deploy top level method #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukclivecox
changed the title
ukclivecox
changed the title
axsaucedo
reviewed
Jun 14, 2021
|
Just to provide more specific thoughts, the top level deploy is good, the rename k8s to manifest as well, and remote to predict makes sense, only thing that woudl be good to dive into further is the update to |
|
lgtm - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploytop level method for normal and asyncto_k8s_yamltomanifestremotetopredictKeeps existing Runtimes as is. Future PR can simply the options and remove unnecessary code.