Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Outlier example #52

Merged
merged 5 commits into from
Mar 18, 2021
Merged

WIP: Outlier example #52

merged 5 commits into from
Mar 18, 2021

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Mar 15, 2021

  • Show multi-stage pipeline
  • Removes __get__ methods for class use as not needed if we use the set_cls process to inject self
  • Allows class instances to be called as functions
  • Adds a deployed state which is set when saving pickle to ensure .remote is called when pipeline is not running locally and needs to call other pipelines
  • Fixed use of V2 dataplane on returned objects
  • Model needed to be extended so you can use a class rather than function for custom models.

Discussion:

  • dill and cloudpickle do not work well together. Dill is used in alibi-detec
  • added unload method so can save artifacts without alibi-detect outlier object
  • Need a way to get MLServer folder

Remaining issues

@ukclivecox ukclivecox merged commit 7f5d126 into SeldonIO:master Mar 18, 2021
@ukclivecox ukclivecox deleted the outlier branch April 16, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant