Minimal models for remote #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukclivecox
suggested changes
Apr 2, 2021
docs/examples/intro/local.md
Outdated
| @@ -115,32 +126,23 @@ We provide a conda yaml in out `local_folder` which tempo will use as the runtim | |||
|
|
|||
|
|
|||
| ```python | |||
There was a problem hiding this comment.
- Wrong location for conda.yaml
- Also I changed to use file syntax for consistency and clarity
- wrong version of mlserver
%%writetemplate artifacts/classifier/conda.yaml
name: tempo
channels:
- defaults
dependencies:
- python=3.7
- pip:
- mlops-tempo @ file://{TEMPO_DIR}
- mlserver==0.3.1.dev7
Also not need to remove this file from github and add to .gitignore as its generated.
docs/examples/intro/k8s.md
Outdated
| @@ -117,32 +118,23 @@ We provide a conda yaml in out `local_folder` which tempo will use as the runtim | |||
|
|
|||
|
|
|||
| ```python | |||
| %%writefile artifacts/classifier/conda.yaml | |||
There was a problem hiding this comment.
Same changes needed here as in local.ipynb
| @@ -0,0 +1,453 @@ | |||
| { | |||
There was a problem hiding this comment.
Needs same changes as other notebooks,
RafalSkolasinski
changed the title
|
Fixed notebooks:
Added:
|
RafalSkolasinski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54