Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEDriverServer 2.46 crashing while trying to read the message text of non standard alert #651

Closed
sroyal5990 opened this issue Jun 11, 2015 · 1 comment

Comments

@sroyal5990
Copy link

In the GetDirectUIDialogText() method of Alert.cpp when the program attempts at get the name of message_text_object (hr = message_text_object->get_accName(child_id, &text_bstr)) if the object doesn't have a name then this will fail to get a name and return S_FALSE. This is a problem because the FAILED(hr) function doesn't catch this due to S_FALSE equaling 1 while FAILED only checks for negative numbers. When the program tries to assign text_bstr to text it will crash due to text_bstr being null. It seems like the check to see if getting the accName property failed should include checking for S_FALSE as this also indicates a failure to get the accName property.

@jimevans
Copy link
Member

Fixed and landed in bb5ca71

@lock lock bot locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants