-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation notice about urllib3[secure] in setup.py #10932
Conversation
pyOpenSSL and urllib3[secure] are deprecated in the upcoming release of (1.26.12) Removed [secure] extra from the urllib3 dependencies
pyOpenSSL and urllib3[secure] are deprecated in the upcoming release (1.26.12) urllib3/urllib3#2680
Thanks @umarfarouk98, its slightly more complicated in the project due to multi languages and using |
Removed urllib3[secure] dependency
Codecov Report
@@ Coverage Diff @@
## trunk #10932 +/- ##
=======================================
Coverage 50.43% 50.43%
=======================================
Files 84 84
Lines 5480 5480
Branches 279 279
=======================================
Hits 2764 2764
Misses 2437 2437
Partials 279 279 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@symonk you wlcm. |
I couldn't find any reference to the secure extra in any requirements files either, so I think this LGTM (my bazel knowledge is very light 😄 ) |
it's not @symonk it's true that the Build.bazel contained the secure[extra] dependency initially but i removed it already. |
Description
pyOpenSSL and urllib3[secure] are deprecated in the upcoming release (1.26.12)
urllib3/urllib3#2680
Removed [secure] extra from the urllib3 dependency in setup.py
Changed 'urllib3[secure, socks]
=1.26 to 'urllib3[socks]=1.26'