-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to start phantomjs with remote debugger in ruby webdriver #11
Conversation
One thing preoccupies me: because I can't take ownership of all the PhantomJSDriver bindings, discrepancies and functionality mis-matches might become too many in the long run... |
@detro feel free to update them in the selenium tree (you have the commit bit) or you could distribute your own gem or pypi package ;) |
@lukeis In other words, I have to "chill out" :) I'm not in the know for either Python (very little knowledge) or Ruby or C#. Hence I couldn't contribute anything useful there. Well, unless I focus on that instead of actually finishing the WireProtocol implementation and fixing the issues. In other words, "nevermind" :) |
Thanks, but I prefer the ability specify arbitrary arguments to the phantomjs executable as suggested here. Closing this. |
Looks like I don't have the permission to close PRs. @krosenvold? |
@jarib that looks great! |
Closed in favor of suggestion in #8. |
…port fix for bug 438807
I love being able to use phantomjs as a webdriver in ruby, but miss the remote
debugger which was so easily exposed via poltergeist.
This pull adds the capability to start the phantomjs service with the remote
debugger listening.
Still not sure how to expose this in the actual browser or bridge. Might require
adding another driver extension, maybe HasDebugger with #debug. Thoughts?
(I have signed the CLA.)