Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get distinct capabilities of the nodes registered with a hub as JSON #12

Closed
wants to merge 1 commit into from

Conversation

dnillia
Copy link

@dnillia dnillia commented Feb 4, 2013

Currently, there is no way to retrieve the list (in a form of JSON) of distinct capabilities across all nodes registered with a hub, even though it is possible to see them as HTML by navigating to "/grid/console". It would be helpful to avoid any attempts to parse HTML in order to get capabilities and instead expose a path like "/grid/capabilities" that will result in JSON representing distinct capabilities. This may be helpful if one wants to dynamically create drivers without providing explicit details.

EDIT: the CLA has been signed.

@cschooler
Copy link

This look really cool. I can see some interesting usages for this functionality.

@alex-savchuk
Copy link
Contributor

Hi!

Thank you for submitting this pull request!

But i have some suggestions:

  1. full feature is expected to include tests covers this feature. Could you implement it? Please take a look at existed set, e.g. https://code.google.com/p/selenium/source/browse/java/server/test/org/openqa/grid/e2e/node/SmokeTest.java
  2. i'd suggest to register servlet at /grid/api/console path.
    Such path mentions that it's API and in future can be extended for returned information w/o URL change.
  3. for what purpose you need distinct set of grid capabilities ?
    why not return all capabilities in format (just for example): {'nodes': {'proxyid' => [ { test slot capabilities }, .. ], ..}} ?
    It could be extended w/o affecting existed users.
  4. (future request) what's about node ? could you implement the similar API point for node?

@andreastt
Copy link
Member

Closing this for lack of response. Please comment if you'd like us to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants