Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Fix type error in mypy #13482

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[py] Fix type error in mypy #13482

merged 1 commit into from
Jan 22, 2024

Conversation

take0x
Copy link
Contributor

@take0x take0x commented Jan 22, 2024

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Because the return type of the add_argument method was not specified, mypy generated a no-untyped-call error.
This error occurs when you call the add_argument method in a typed method.

Motivation and Context

This change will help you avoid unexpected errors that may be generated by typecheckers.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a3b1124) 58.46% compared to head (737e99d) 58.48%.

❗ Current head 737e99d differs from pull request most recent head 6047967. Consider uploading reports for the commit 6047967 to get more accurate results

Files Patch % Lines
py/selenium/webdriver/common/options.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13482      +/-   ##
==========================================
+ Coverage   58.46%   58.48%   +0.01%     
==========================================
  Files          86       86              
  Lines        5270     5270              
  Branches      220      220              
==========================================
+ Hits         3081     3082       +1     
+ Misses       1969     1968       -1     
  Partials      220      220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner titusfortner merged commit 1164555 into SeleniumHQ:trunk Jan 22, 2024
14 checks passed
@titusfortner
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants