-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[js] Making SeleniumManager a thin wrapper #13853
Conversation
PR Description updated to latest commit (477a95b)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
CI Failure Feedback
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
Type
enhancement
Description
getBinaryPaths
.getArgs
indriverFinder.js
to consolidate argument preparation for binary path retrieval.driverFinder.js
for better clarity when driver paths cannot be resolved.Changes walkthrough
7 files
chromium.js
Refactor and Enhance Driver Initialization in Chromium Driver
javascript/node/selenium-webdriver/chromium.js
getBinaryPaths
instead ofgetPath
for driver andbrowser path resolution.
BROWSER_VERSION
from capabilities in multipleplaces.
driverFinder.js
Refactor Driver Path Resolution and Argument Handling
javascript/node/selenium-webdriver/common/driverFinder.js
getPath
togetBinaryPaths
to better reflect its functionality.getArgs
function to consolidate argument preparation for binarypath retrieval.
seleniumManager.js
Streamline Binary Path Resolution in Selenium Manager
javascript/node/selenium-webdriver/common/seleniumManager.js
driverLocation
tobinaryPaths
.driverFinder.js
.BROWSER_VERSION
after path resolution.firefox.js
Update Firefox Driver Initialization with Enhanced Path Resolution
javascript/node/selenium-webdriver/firefox.js
getBinaryPaths
for resolving driver and browser paths.ie.js
Update IE Driver Initialization and Command Line Handling
javascript/node/selenium-webdriver/ie.js
getBinaryPaths
.safari.js
Update Safari Driver Initialization with New Path Resolution Method
javascript/node/selenium-webdriver/safari.js
getBinaryPaths
for driver path resolution.index.js
Enhance Browser Detection in Testing Utilities
javascript/node/selenium-webdriver/testing/index.js
getBinaryPaths
for determiningavailable browsers.
2 files
service_test.js
Update Chrome Driver Service Tests with New Path Resolution
javascript/node/selenium-webdriver/test/chrome/service_test.js
getBinaryPaths
for setting executable paths intests.
service_test.js
Update Edge Driver Service Tests with Enhanced Path Resolution
javascript/node/selenium-webdriver/test/edge/service_test.js
getBinaryPaths
.