-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] implement WebDriver BiDi with WebDriverBiDi dependency #14052
base: trunk
Are you sure you want to change the base?
Conversation
CI Failure Feedback 🧐(Checks updated until commit 69c568e)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not introduce new external dependencies.
903bc2b
to
5d176cb
Compare
…age load strategy
5d176cb
to
69c568e
Compare
This PR is to evaluate the high level API
Status
This is in draft because:
Description
webSocketUrl
is setMotivation and Context
.NET implementation of #13995
The conditionals in each method are not the most elegant, but they are straightforward, and I think that's preferred.
It'll be easy enough to just remove the conditionals (and probably the Sync methods as well) when we remove support for WebDriver classic (likely Selenium 6)
Considerations
This sidesteps updating
browsingContextId
from context changes; we'll handle that separatelyStill need to sort out creating new bidi bazel targets properly
attn: @YevgeniyShunevych