You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the ruby library was throwing an error when the option silent was set to true for internet explorer, and that it was not implemented as it is in the js or java bindings
Motivation and Context
It's important that all the bindings support the same w3c options and that our documentation is up to day:
Why: The suggestion correctly identifies a consistency issue in the naming convention of the keys in the options hash. Prefixing with 'ie.' aligns with existing keys and improves code consistency.
8
Test coverage
Add a test case to verify the default value of the new option
Add a test case to verify the default value of the silent option to ensure it behaves correctly when not explicitly set.
Why: Adding a test case to verify the default behavior of the new silent option is important for ensuring expected functionality when the option is not set. This enhances test coverage and reliability.
7
Add a test to verify that the new option is passed to the driver
Ensure that the silent option is correctly passed to the underlying driver by adding a test that checks the final capabilities.
Why: The suggestion to verify that the silent option is passed correctly to the driver is valid and improves the test suite by ensuring that the option affects the driver's behavior as expected.
7
Add a test to verify that the new option can be disabled
Consider adding a test that sets the silent option to false to ensure that the option can be correctly disabled.
Why: This suggestion is useful as it proposes testing the ability to disable the silent option, which is crucial for verifying that the option can be toggled as expected, enhancing the robustness of the test suite.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
While working on improving the documentation for the ruby library on this pr: SeleniumHQ/seleniumhq.github.io#1748
I noticed that the ruby library was throwing an error when the option silent was set to true for internet explorer, and that it was not implemented as it is in the js or java bindings
Motivation and Context
It's important that all the bindings support the same w3c options and that our documentation is up to day:
Current docs: https://www.selenium.dev/documentation/webdriver/browsers/internet_explorer/
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
silent
option in the Internet Explorer options for the Ruby library.options.rb
to include thesilent
key.options_spec.rb
to verify thesilent
option is correctly set and handled.Changes walkthrough 📝
options.rb
Add support for `silent` option in IE options
rb/lib/selenium/webdriver/ie/options.rb
silent
option in Internet Explorer options.silent
key.options_spec.rb
Add tests for `silent` option in IE options
rb/spec/unit/selenium/webdriver/ie/options_spec.rb
silent
option in Internet Explorer options.silent
option is correctly set in various test cases.