added new exception, changing isElementClickable to return a more spe… #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for issue #1704 |
|
Opened a spec bug to support this new error code: https://www.w3.org/Bugs/Public/show_bug.cgi?id=29585 |
JamesZoft
force-pushed
the
1704_specific_exception_element_not_clickable
branch
from
d9f96ea
to
693136d
Compare
added 4 commits
March 21, 2017 17:23
…tored in the last year, changing so that there isnt random java code in here and added INTERCEPTING_ELEMENT_ERROR to the knownerror stuff
shs96c
reviewed
Mar 29, 2017
| package org.openqa.selenium; | ||
|
|
||
| /** | ||
| * Created by James Reed on 11/04/2016. |
There was a problem hiding this comment.
We keep who wrote the code anonymous.
There was a problem hiding this comment.
Oops, sorry. Auto comment generation :(
| @@ -74,6 +75,7 @@ | |||
| public static final int ELEMENT_NOT_VISIBLE = 11; | |||
| public static final int INVALID_ELEMENT_STATE = 12; | |||
| public static final int UNHANDLED_ERROR = 13; | |||
| public static final int INTERCEPTING_ELEMENT_ERROR = 14; | |||
There was a problem hiding this comment.
Is this just a random number? Can't remember if we have this defined elsewhere.
There was a problem hiding this comment.
I honestly cannot remember any particular reason for 14. I think it may have just been a gap in the existing numbers and I went for it. I can change it to something else if wanted.
|
Superceded by bd9d415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement…cific error