Change proxy to not depend on node util module #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * @fileoverview Defines functions for configuring a webdriver proxy: | ||
| * | ||
| * var webdriver = require('selenium-webdriver'), |
There was a problem hiding this comment.
Everything in the lib directory is intended to be environment agnostic, so please don't reference node-specific modules.
There was a problem hiding this comment.
@jleyba thanks, updated. Let me know if it needs further changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreementutil.isArrayis deprecated in node 4, changed toArray.isArray.Please consider accepting this, it makes it easier to use in browsers. Thanks.
Not sure why travis is failing, seems unrelated to the pr. Also need some help to get the node tests pass with firefox #2390. I'm happy to make adjustments to meet your standard.