-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change SearchContext
so that findElements
can return a list that sub-classes WebElement
#604
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
958f7ed
Modify SearchContext.findElements to allow implementing classes to re…
alexec dc4b39d
Modify SearchContext.findElements to allow implementing classes to re…
alexec 96928e8
Merge branch 'master' of https://github.com/alexec/selenium
alexec 4a1b567
Fixed merge issue.
alexec 3d030f0
Modify SearchContext.findElements to allow implementing classes to re…
alexec 755ca76
Merge branch 'master' of https://github.com/alexec/selenium
alexec f51db08
Modified SearchContext.findElements to return List<? extends WebElement>
alexec 562eddc
Modified SearchContext.findElements: <W extends WebElement> List<W> f…
alexec 0b73940
SearchContext interface is made generic
alexec f349194
Merge branch 'master' of https://github.com/alexec/selenium
alexec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
java/client/test/org/openqa/selenium/SearchContextTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
package org.openqa.selenium; | ||
|
||
import org.junit.Test; | ||
|
||
import java.util.List; | ||
|
||
// this class just tests we can compile the code | ||
public class SearchContextTest { | ||
|
||
private final SubClassingSearchContext subClassingSearchContext = new SubClassingSearchContext(); | ||
private final SameClassSearchContext sameClassSearchContext = new SameClassSearchContext() { | ||
@Override | ||
public List<WebElement> findElements(By by) { | ||
return null; | ||
} | ||
|
||
@Override | ||
public WebElement findElement(By by) { | ||
return null; | ||
} | ||
}; | ||
|
||
private interface TestWebElement extends WebElement { | ||
|
||
} | ||
|
||
private static class SubClassingSearchContext implements SearchContext { | ||
|
||
@Override | ||
public List<TestWebElement> findElements(By by) { | ||
return null; | ||
} | ||
|
||
@Override | ||
public TestWebElement findElement(By by) { | ||
return null; | ||
} | ||
} | ||
|
||
private interface SameClassSearchContext extends SearchContext { | ||
|
||
} | ||
|
||
@Test | ||
public void makeSureFindElementsIsBackwardsCompatible() throws Exception { | ||
|
||
@SuppressWarnings("unused") | ||
List<? extends WebElement> elements = sameClassSearchContext.findElements(null); | ||
} | ||
|
||
@Test | ||
public void makeSureFindElementIsBackwardsCompatible() throws Exception { | ||
|
||
@SuppressWarnings("unused") | ||
WebElement element = sameClassSearchContext.findElement(null); | ||
} | ||
|
||
@Test | ||
public void makeSureFindElementsCanUseSuperClass() throws Exception { | ||
@SuppressWarnings("unused") | ||
List<TestWebElement> elements = subClassingSearchContext.findElements(null); | ||
} | ||
|
||
@Test | ||
public void makeSureFindElementCanUseSuperClass() throws Exception { | ||
|
||
@SuppressWarnings("unused") | ||
WebElement element = subClassingSearchContext.findElement(null); | ||
|
||
|
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?