Added a basic ServiceBuilder for Internet Explorer #6181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds it to IE's `Driver` and allows it to be specified with a new `setIeService` in the general `Builder`. Fixes #5983
jleyba
requested changes
Jul 27, 2018
| * @return {!Builder} a self reference. | ||
| */ | ||
| setIeService(service) { | ||
| this.ieService_ = service; |
There was a problem hiding this comment.
this.ieService_ should be initialized to null in the constructor.
grigaman
pushed a commit
to grigaman/selenium
that referenced
this pull request
Sep 20, 2018
* Added a basic ServiceBuilder for Internet Explorer Adds it to IE's `Driver` and allows it to be specified with a new `setIeService` in the general `Builder`. Fixes SeleniumHQ#5983 * Added IE service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds it to IE's
Driverand allows it to be specified with a newsetIeServicein the generalBuilder.Fixes #5983.
I'm very unfamiliar with all this, so other than verifying that it works locally, I haven't written tests. It looks pretty similar to the existing service builders, but confirmation would be nice!
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementEdit: some test jobs pass, some fail. 🤷