Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Test to Target #7250

Merged
merged 2 commits into from
May 30, 2019
Merged

Add Test to Target #7250

merged 2 commits into from
May 30, 2019

Conversation

dratler
Copy link
Contributor

@dratler dratler commented May 30, 2019

  1. Add ChromeDevToolsTargetTest.java with Target test
  2. Add it to DevToolsTest

dratler and others added 2 commits May 30, 2019 18:01
@dratler
Major :
0a8adba 
1. Add ChromeDevToolsTargetTest.java with Target test
2. Add it to DevToolsTest
remove setting
b4a1ea7
@dratler
Copy link
Contributor Author

dratler commented May 30, 2019

This PR is related to #6667.
@shs96c please share if something is missing

@shs96c
Copy link
Member

shs96c commented May 30, 2019

Thanks for the PR. This looks good, though I'd recommend against changing the shared config files in future (unless that's the point of your PR :) )

@shs96c
Copy link
Member

shs96c commented May 30, 2019

Merging now. Congratulations!

@shs96c shs96c merged commit a58f49b into SeleniumHQ:master May 30, 2019
@dratler dratler deleted the addTragetTests branch May 30, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dratler @shs96c