Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a NullPointerException #9

Closed
wants to merge 1 commit into from
Closed

Fixed a NullPointerException #9

wants to merge 1 commit into from

Conversation

cschooler
Copy link

I fixed a NullPointerException which occurred when a JsonWireProtocol request was made without a session. This made debugging issues difficult since it hid the message indicating that a session was not available. No issue was logged to the project's issue list since it is in a read only status for network maintenance.

…Protocol call; masking the useful message intended for this situation, making it difficult to debug other issues.
@lukeis
Copy link
Member

lukeis commented Jan 30, 2013

didn't make sense to me why this would be a null pointer till i read the java doc on ConcurrentHashMap
http://docs.oracle.com/javase/1.5.0/docs/api/java/util/concurrent/ConcurrentHashMap.html
sigh

can you confirm you've signed the cla?
http://goo.gl/qC50R

@cschooler
Copy link
Author

I have signed the cla

On Jan 30, 2013, at 5:08 PM, Luke Inman-Semerau notifications@github.com
wrote:

didn't make sense to me why this would be a null pointer till i read the
java doc on ConcurrentHashMap
http://docs.oracle.com/javase/1.5.0/docs/api/java/util/concurrent/ConcurrentHashMap.html
sigh

can you confirm you've signed the cla?
http://goo.gl/qC50R


Reply to this email directly or view it on
GitHubhttps://github.com//pull/9#issuecomment-12917984.

@lukeis
Copy link
Member

lukeis commented Jan 30, 2013

merged with 8d136ef

you should be able to rebase your clone "git pull --rebase"

@lukeis lukeis closed this Jan 30, 2013
@lukeis
Copy link
Member

lukeis commented Jan 30, 2013

thanks for the patch! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants