Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using an Icon in a Header ignores Icon size prop #4296

Closed
adamvanaken opened this issue Oct 12, 2021 · 2 comments
Closed

Using an Icon in a Header ignores Icon size prop #4296

adamvanaken opened this issue Oct 12, 2021 · 2 comments
Labels

Comments

@adamvanaken
Copy link

adamvanaken commented Oct 12, 2021

Bug Report

Steps

Using an Icon in a Header ignores the Icon size prop.

I understand that I could easily override the styling, but I don't want to potentially break or miss out on future styling updates by doing so.

Expected Result

I would expect to be able to size Icons inside Headers.

Actual Result

The .ui.header>.icon style overrides the font-size that, as an example, the i.small.icon style sets.

Version

2.0.4

Testcase

https://codesandbox.io/s/semantic-ui-react-forked-38ue7

image

@brianespinosa
Copy link
Member

Hi @adamvanaken

We can see from your example that the class names are being added as expected, as you can tell that those classes are being attached and then overridden by more specific class styles of the header. We do not have any of the CSS in this repository. I would recommend creating an issue in the parent SUI repository where our class names come from. I do not know if that was an intentional design decision, or if it was a miss.

@adamvanaken
Copy link
Author

@brianespinosa fair enough; created an issue in the CSS repo: Semantic-Org/Semantic-UI-CSS#73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants