docs(examples): fix in webpack1 example #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Apr 18, 2017
| @@ -5,7 +5,6 @@ | |||
| "stage-1" | |||
| ], | |||
| "plugins": [ | |||
| "lodash", | |||
| ["lodash", { "id": "semantic-ui-react" }] | |||
| ["lodash", { "id": ["lodash", "semantic-ui-react"] }] | |||
There was a problem hiding this comment.
We can run resolution updates in single run.
layershifter
commented
Apr 18, 2017
| @@ -8,6 +8,6 @@ | |||
| </head> | |||
| <body> | |||
| <div id="root" style="height: 100%"></div> | |||
| <script src="./dist/bundle.js"></script> | |||
| <script src="./dist/app.js"></script> | |||
layershifter
commented
Apr 18, 2017
| @@ -17,4 +17,4 @@ const App = () => ( | |||
| </Container> | |||
| ) | |||
|
|
|||
| render(App, MOUNT_NODE) | |||
| render(<App />, MOUNT_NODE) | |||
Codecov Report
@@ Coverage Diff @@
## master #1596 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 141 141
Lines 2384 2384
=======================================
Hits 2378 2378
Misses 6 6Continue to review full report at Codecov.
|
|
Whoops, I should have caught these issues in review! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.