Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of deprecated wfWikiID() #105

Closed
wants to merge 1 commit into from

Conversation

Func86
Copy link

@Func86 Func86 commented Jan 12, 2022

The global function wfWikiID() is hard deprecated since 1.38, and its usages should be replaced with WikiMap::getCurrentWikiId().

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

The global function wfWikiID() is hard deprecated since 1.38, and its usages should be replaced with WikiMap::getCurrentWikiId().
@krabina
Copy link
Contributor

krabina commented Aug 28, 2023

When I checkout your version, I get the following

Fatal error: Uncaught UnexpectedValueException: callback 'SemanticCite::initExtension' is not callable in includes/registration/ExtensionRegistry.php:525
Stack trace:
#0 includes/registration/ExtensionRegistry.php(279): ExtensionRegistry->exportExtractedData()
#1 includes/Setup.php(278): ExtensionRegistry->loadFromQueue()
#2 maintenance/doMaintenance.php(83): require_once('/home/knowledge...')
#3 maintenance/update.php(312): require_once('/home/knowledge...')
#4 {main}
  thrown in includes/registration/ExtensionRegistry.php on line 525

@kizule
Copy link
Contributor

kizule commented Nov 20, 2023

This is already done in #116 by @thomas-topway-it, so I think that this PR can be closed.

@krabina krabina closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants