Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React native documentation #2841

Merged
merged 1 commit into from
Feb 9, 2022
Merged

React native documentation #2841

merged 1 commit into from
Feb 9, 2022

Conversation

tpmai22
Copy link
Contributor

@tpmai22 tpmai22 commented Feb 5, 2022 •
edited
Loading

Issue This PR Addresses

#2733

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Adding react-native documentation follow #2733

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Feb 5, 2022

@tpmai22 tpmai22 force-pushed the issue-2733 branch 2 times, most recently from 8b7ca0f to b762a3a Compare February 5, 2022 04:32
HyperTHD
HyperTHD requested changes Feb 5, 2022
View reviewed changes
docs/react-native.md Outdated Show resolved Hide resolved
docs/react-native.md Outdated Show resolved Hide resolved
@aserputov aserputov self-requested a review February 5, 2022 13:25
@aserputov aserputov added area: React Native type: documentation (docs) Improvements or additions to documentation labels Feb 5, 2022
@aserputov aserputov added this to the 2.7 Release milestone Feb 5, 2022
humphd
humphd requested changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you should include a screenshot?

docs/react-native.md Outdated Show resolved Hide resolved
docs/react-native.md Outdated Show resolved Hide resolved
docs/react-native.md Outdated Show resolved Hide resolved
docs/react-native.md Outdated Show resolved Hide resolved
docs/react-native.md Outdated Show resolved Hide resolved
JerryHue
JerryHue requested changes Feb 5, 2022
View reviewed changes
docs/react-native.md Outdated Show resolved Hide resolved
docs/react-native.md Outdated Show resolved Hide resolved
docs/react-native.md Show resolved Hide resolved
humphd
humphd requested changes Feb 5, 2022
View reviewed changes
docs/react-native.md Outdated Show resolved Hide resolved
docs/react-native.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@tpmai22 tpmai22 requested a review from humphd February 5, 2022 20:59
Kevan-Y
Kevan-Y requested changes Feb 6, 2022
View reviewed changes
Copy link
Contributor

@Kevan-Y Kevan-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can add, some links to install IOS and Android Emulator.
I'm pretty sure contributors will use emulators during development over using their own devices.

IOS Emulator Installation
Android Emulator Installation

@tpmai22
Copy link
Contributor Author

tpmai22 commented Feb 6, 2022

@Kevan-Y I already have links to the xCode and Android Studio but this work as well

@tpmai22 tpmai22 requested a review from Kevan-Y February 7, 2022 15:06
Kevan-Y
Kevan-Y previously approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@Kevan-Y Kevan-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cindyorangis
cindyorangis previously approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@cindyorangis cindyorangis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good base. We can iterate on this later.

@humphd
Copy link
Contributor

humphd commented Feb 9, 2022

@tpmai22 can you get this landed soon?

@tpmai22
Copy link
Contributor Author

tpmai22 commented Feb 9, 2022

@humphd I just need to wait for suggestion but I think it pretty much done

@tpmai22 tpmai22 dismissed stale reviews from cindyorangis and Kevan-Y via 78e0b6e February 9, 2022 17:01
@tpmai22 tpmai22 merged commit b1156d7 into Seneca-CDOT:master Feb 9, 2022
@dbelokon dbelokon mentioned this pull request Feb 12, 2022
Closed
2 tasks
@tpmai22 tpmai22 mentioned this pull request Feb 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevan-Y Kevan-Y Kevan-Y left review comments

@cindyorangis cindyorangis cindyorangis left review comments

@aserputov aserputov Awaiting requested review from aserputov

@JerryHue JerryHue Awaiting requested review from JerryHue

@HyperTHD HyperTHD Awaiting requested review from HyperTHD

@humphd humphd Awaiting requested review from humphd

Assignees

@tpmai22 tpmai22

Labels
area: React Native type: documentation (docs) Improvements or additions to documentation
Projects
None yet
Milestone
2.7 Release
Development

Successfully merging this pull request may close these issues.
7 participants
@tpmai22 @humphd @HyperTHD @cindyorangis @JerryHue @Kevan-Y @aserputov