Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing for missing title given as [Object] #3679

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

RC-Lee
Copy link
Contributor

@RC-Lee RC-Lee commented Oct 5, 2022

Issue This PR Addresses

Fixes #3652

Type of Change

  • Bugfix: Change which fixes an issue

Description

Added parsing for missing titles from posts that are given to us as an { '$': { type: 'text' } } object

Steps to test the PR

  1. Change feeds.json to have the single feed for easy testing.
[
  {
    "url": "http://compiledsprawl.blogspot.com/feeds/posts/default/-/open-source",
    "user_id": null,
    "wiki_author_name": "Matthew Grosvenor",
    "html_url": null,
    "type": "blog",
    "invalid": false,
    "flagged": false,
    "id": "a394d88c0e"
  }
]
  1. Clear redis cache, do db migrations
  2. Blog post will appear on the main page and in search
    image

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Oct 5, 2022

Copy link
Contributor

@cindyorangis cindyorangis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it when you leave comments in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic search unable to index document with Object for title
3 participants