-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docviewer refact part2 #1101
Docviewer refact part2 #1101
Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #1101 +/- ##
===========================================
- Coverage 93.80% 93.77% -0.03%
===========================================
Files 227 232 +5
Lines 6166 6554 +388
Branches 1634 1678 +44
===========================================
+ Hits 5784 6146 +362
- Misses 382 408 +26
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- comment marker placement is wrong placed to rotated page
- if redaction / shape visibility is disabled, it should become active when I add one to the document.
Backend problems:
Must check:
UNIT TESTS:
The popper parts cannot be tested with jest:
floating-ui/floating-ui#478
Material ui uses popper.js and you cannot test this component with JSDOM it needs the browser DOM APIs.
ACTION PLAN FOR THE FUTURE: