Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docviewer refact part2 #1101

Merged
merged 22 commits into from
Jan 20, 2021
Merged

Docviewer refact part2 #1101

merged 22 commits into from
Jan 20, 2021

Conversation

enikonemeth
Copy link
Contributor

@enikonemeth enikonemeth commented Dec 8, 2020

Backend problems:

Must check:

  • which permission you need for drawing a shape?

UNIT TESTS:

The popper parts cannot be tested with jest:
floating-ui/floating-ui#478
Material ui uses popper.js and you cannot test this component with JSDOM it needs the browser DOM APIs.

2020-12-18_14h06_04
2020-12-18_14h05_56
2020-12-18_14h05_59
2020-12-18_14h06_02

ACTION PLAN FOR THE FUTURE:

  • blogpost about the new features

@enikonemeth enikonemeth added this to the Sprint 225 milestone Dec 8, 2020
@enikonemeth enikonemeth self-assigned this Dec 8, 2020
@sensenet
Copy link

sensenet bot commented Dec 8, 2020

Site name Url Last deploy
sn-react-component-docs-dev https://60080ac3397f13b8b757072e--sn-react-component-docs-dev.netlify.app Wed Jan 20 2021 - 10:49:42 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://60080ac4134147c919b3123c--sn-app-dev.netlify.app Wed Jan 20 2021 - 10:49:43 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #1101 (1ac787d) into develop (7e92ab4) will decrease coverage by 0.02%.
The diff coverage is 94.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1101      +/-   ##
===========================================
- Coverage    93.80%   93.77%   -0.03%     
===========================================
  Files          227      232       +5     
  Lines         6166     6554     +388     
  Branches      1634     1678      +44     
===========================================
+ Hits          5784     6146     +362     
- Misses         382      408      +26     
Impacted Files Coverage Δ
...document-viewer-react/src/context/api-settings.tsx 20.96% <0.00%> (ø)
...-viewer-react/src/context/localization-context.tsx 100.00% <ø> (ø)
...document-viewer-react/src/context/viewer-state.tsx 50.00% <ø> (ø)
...viewer-react/src/services/apply-shape-rotations.ts 50.00% <45.45%> (-50.00%) ⬇️
...r-react/src/components/shapes/shape-annotation.tsx 78.04% <76.31%> (-21.96%) ⬇️
...er-react/src/components/shapes/shape-redaction.tsx 85.71% <85.18%> (-14.29%) ⬇️
...er-react/src/components/shapes/shape-highlight.tsx 86.66% <85.71%> (-13.34%) ⬇️
...ment-viewer-react/src/components/shapes/shapes.tsx 96.72% <92.30%> (+0.16%) ⬆️
...document-viewer-react/src/components/page-list.tsx 91.56% <93.75%> (+0.42%) ⬆️
...s/sn-document-viewer-react/src/components/page.tsx 96.11% <95.89%> (-1.26%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e92ab4...1ac787d. Read the comment docs.

@enikonemeth enikonemeth marked this pull request as ready for review December 18, 2020 13:36
@herflis herflis modified the milestones: Sprint 225, Sprint 226 Jan 3, 2021
@herflis herflis modified the milestones: Sprint 226, Sprint 227 Jan 7, 2021
Copy link
Contributor

@taki9 taki9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • comment marker placement is wrong placed to rotated page
  • if redaction / shape visibility is disabled, it should become active when I add one to the document.

@enikonemeth enikonemeth merged commit 7a8c6c3 into develop Jan 20, 2021
@enikonemeth enikonemeth deleted the fix/preview_refact_part2 branch January 20, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants