Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request: complete schedule fixes #189

Closed
PhilZ-cwm6 opened this issue Oct 10, 2020 · 1 comment
Closed

Pull request: complete schedule fixes #189

PhilZ-cwm6 opened this issue Oct 10, 2020 · 1 comment

Comments

@PhilZ-cwm6
Copy link
Contributor

Pull request: #188

I completed my previous patch after your merge.
I am done with that part

Changes:

  • translation fr:
    • shorten some messages to fit the screen if needed because the max allowed error lines is 3 (Fr/eng)
  • remove now unused messages
  • do not show the schedule button when schedule list is empty + ensure NPE handling
  • add missing space between Edit Schedule title and Schedule name in the EditSchedule dialog
  • translate the new created schedule name
  • if all auto-generated schedule names exist (>1000), do not rely on xml layout text field but on the translated new name message: this avoids a NPE if the layout text is removed in some code maintenance
  • never modify the edited schedule name even if it is empty: do not change the schedule and throw an error message so user can rename it
  • if an edited schedule has a null name (settings file corruption), notify the error
  • add a few NPE checks also when renaming sync tasks and schedules

Thank you and best regards

@PhilZ-cwm6
Copy link
Contributor Author

PhilZ-cwm6 commented Oct 11, 2020

Sorry, I again forgot a small check in copy/paste the code
Fixed properly now in #190

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant