Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the previous patch to schedules + small fixes #188

Merged
merged 3 commits into from
Oct 10, 2020

Conversation

PhilZ-cwm6
Copy link
Contributor

  • translation fr:
    • shorten some messages to fit the screen if needed because the max allowed error lines is 3 (Fr/eng)
  • remove now unused messages
  • do not show the schedule button when schedule list is empty + ensure NPE handling
  • add missing space between Edit Schedule title and Schedule name in the EditSchedule dialog
  • translate the new created schedule name
  • if all auto-generated schedule names exist (>1000), do not rely on xml layout text field but on the translated new name message: this avoids a NPE if the layout text is removed in some code maintenance
  • never modify the edited schedule name even if it is empty: do not change the schedule and throw an error message so user can rename it
  • if an edited schedule has a null name (settings file corruption), notify the error
  • add a few NPE checks also when renaming sync tasks and schedules

do not show the schedule button when schedule list is empty + ensure NPE handling
- add missing space between Edit Schedule title and Schedule name in the EditSchedule dialog
- translate the new created schedule name
- if all auto-generated schedule names exist (>1000), do not rely on xml layout text field but on the translated new name message: this avoids a NPE if the layout text is removed in some code maintenance
- never modify the edited schedule name even if it is empty: do not change the schedule and throw an error message so user can rename it
- if an edited schedule has a null name (settings file corruption), notify the error
- add a few NPE checks also when renaming sync tasks and schedules
@PhilZ-cwm6 PhilZ-cwm6 changed the title Patch 2020.10.10 small fixes Complete the previous patch to schedules + small fixes Oct 10, 2020
@Sentaroh Sentaroh merged commit e7e4c64 into Sentaroh:2.36 Oct 10, 2020
@PhilZ-cwm6 PhilZ-cwm6 deleted the patch_2020.10.10_small_fixes branch October 11, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants