Fix bugs in result_log file names and sync task file name #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- result_log txt file cannot have invalid characters else it will fail to sync to or to be saved to FAT32/NTFS or any windows system This patch preserves the useful ability to name sync tasks freely while ensuring the result.log file is valid - fix result_log file name length could exceed 255 chars - ensure sync task name global length cannot be longer than 150 chars to fix a bug in the EditSyncTask GUI. Also, 150 chars seems more than enough for a sync task name Note: another patch is needed to fix the root cause of the GUI bug in EditSyncTask when the name is too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch preserves the useful ability to name sync tasks freely while ensuring the result.log file is valid
Note: another patch is needed to fix the root cause of the GUI bug in EditSyncTask when the name is too long