Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete the previous patch to schedules + small fixes #188

Merged
merged 3 commits into from
Oct 10, 2020
Merged

Complete the previous patch to schedules + small fixes #188

merged 3 commits into from
Oct 10, 2020

Commits on Oct 10, 2020

  1. Fr translation + remove unused messages

    @PhilZ-cwm6
    PhilZ-cwm6 committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    696ed8f View commit details
    Browse the repository at this point in the history

  2. Hide schedule buttons if empty schedule list + NPE check 

    do not show the schedule button when schedule list is empty + ensure NPE handling
    @PhilZ-cwm6
    PhilZ-cwm6 committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    357cb56 View commit details
    Browse the repository at this point in the history

  3. New Schedule Name translation + NPE checks + small fixes 

    - add missing space between Edit Schedule title and Schedule name in the EditSchedule dialog
- translate the new created schedule name
- if all auto-generated schedule names exist (>1000), do not rely on xml layout text field but on the translated new name message: this avoids a NPE if the layout text is removed in some code maintenance
- never modify the edited schedule name even if it is empty: do not change the schedule and throw an error message so user can rename it
- if an edited schedule has a null name (settings file corruption), notify the error
- add a few NPE checks also when renaming sync tasks and schedules
    @PhilZ-cwm6
    PhilZ-cwm6 committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    c89511c View commit details
    Browse the repository at this point in the history