Translate new menu and small layout adjustments #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PhilZ-cwm6
commented
May 14, 2020
•
PhilZ-cwm6
commented
- translation fix eng/fr for new Zip encode menu
- layout: fix spinner margin in landscape
- layout: remove recently added devider separating main menu title from submenus
- ZIP defaults: code maintenance to match all other settings in code
- ZIP file name: change EditText field to Multiline for proper wrapping and to match other keyword field views
- archive create directory based on shooting date: change EditText field to Multiline for proper wrapping and to match other fields in the view
- landscape: fix margins and landscape layout on small devices for the Edit master/folder dialog mainly in archive view.
- fix layout mis-match issues when rotating from land to portrait in edit master/target archive views
- translation fix eng/fr for new Zip encode menu - layout: fix spinner margin in landscape - layout: remove recently added devider separating main menu title from submenus - ZIP defaults: code maintenance to match all other settings in code - ZIP file name: change EditText field to Multiline for proper wrapping and to match other keyword field views - archive create directory based on shooting date: change EditText field to Multiline for proper wrapping and to match other fields in the view - landscape: fix margins and landscape layout on small devices for the Edit master/folder dialog mainly in archive view. Also fixes issues when rotating from land to portrait in edit master/target archive views
|
Before After Before: main option is not separated by a ligne from sub-options in all other views include this one After: remove the devider to match other layouts and options
Landscape view on a small display: Effects of rotation from landscape to portrait |
|
The Utilities lib update fixed the last visual bug Hope you revert the block rotation |
|
the spinners change layout is not necessarily needed in this commit |
|
will open an issue since you're on the layouts and more changes could bring new merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.