Reorder some rules #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of rules in ANTLR is quite important, as they take precedence based on when they are defined. Here, I'm putting the ALPHA_NUMERIC and ALPHA_NUMERIC_CAP rules below the QUOTED_STRING and NON_QUOTED_STRING rules so that when we find a single-letter identifier (i.e. a file name) ANTLR detects the *_STRING rules before the ALPHA_NUMERIC_* ones. This is most likely caused by a badly defined grammar (and probably the lack of proper fragments). However, this is, I think, a good compromise if we don't want to tackle a full rewrite of the grammar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of rules in ANTLR is quite important, as they take precedence based on when they are defined. Here, I'm putting the ALPHA_NUMERIC and ALPHA_NUMERIC_CAP rules below the QUOTED_STRING and NON_QUOTED_STRING rules so that when we find a single-letter identifier (i.e. a file name) ANTLR detects the STRING rules before the ALPHA_NUMERIC ones.
This is most likely caused by a badly defined grammar (and probably the lack of proper fragments). However, this is, I think, a good compromise if we don't want to tackle a full rewrite of the grammar.
tests/ok/011.pbxproj is a copy of 010.pbxproj adding a directory called
C🎟️ Issue: #52