Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibJS: Now.plainDateTimeISO.js custom time zone test is very flaky #20806

Open
trflynn89 opened this issue Aug 27, 2023 · 0 comments
Open

LibJS: Now.plainDateTimeISO.js custom time zone test is very flaky #20806

trflynn89 opened this issue Aug 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@trflynn89
Copy link
Member

trflynn89 commented Aug 27, 2023

These have been flaky for quite a while, with the following error:

   FAIL  builtins/Temporal/Now/Now.plainDateTime.js
       ❌ Suite:  correct behavior
           Test:   custom time zone positive (failed):
                   ExpectationError: toBe: expected _86400_, got _86399_

   FAIL  builtins/Temporal/Now/Now.plainDateTimeISO.js
       ❌ Suite:  correct behavior
           Test:   custom time zone positive (failed):
                   ExpectationError: toBe: expected _86400_, got _86399_

Quite a bit of work has gone into making these less flaky in the past, see:
c0a3b14
1b0ca52
cf0d30a

However, they still flake, and should be investigated (or maybe it becomes a non-issue when we catch up to the latest Temporal spec).

@trflynn89 trflynn89 added the bug Something isn't working label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant