Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchant Weapon strips Mythic Weapon Buff #5044

Open
paperninja opened this issue Mar 1, 2023 · 1 comment
Open

Enchant Weapon strips Mythic Weapon Buff #5044

paperninja opened this issue Mar 1, 2023 · 1 comment

Comments

@paperninja
Copy link

I was playing around with the mysticism mastery, Mystic Weapon, and I think I found a pretty major bug with it. If you cast Enchant at the same time, your weapon will hold both the mystic and on hit properties. But when Enchant wears off, it will strip all of Mystic Weapon's stats from the weapon as well. It feels like it may even do more than that based on how much I was whiffing and how much damage I was taking when this happened.

Steps to Reproduce:
-Become a master mystic
-Equip a weapon
-Buff with Mystic Weapon
-Buff with Enchant (any effect)
-You can now see the mystic and on hit properties on the weapon (see image)
-Allow Enchant to wear off
-You can now see that the weapon has no mystic property, when it should (see image)
-Despite the Mystic Weapon buff existing on your buff bar, you can still cast it to reapply the effect

How it should work:
Enchant should remove its own effects, but the mystic effect should disappear only when Mystic Weapon wears off

Other notes:
Mystic Weapon is also currently lacking any sort of sounds for casting or fizzling.

Notes: Enchant does not strip Immolate when it wears off. Neither Immolate nor Mystic Weapon strip Enchant.

@dominicrusso
Copy link

I have a fix for this that I can submit. There is a missing parameter in the function call for removing the buff. It should specify which buff is ending but since it doesn't, it ends all the buffs on the weapon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants