JAV-222 when register schema failed, can not find the reason from log. #100
Conversation
|
Changes Unknown when pulling 5ee0109 on wujimin:register-schema-fail-reason into ** on ServiceComb:master**. |
| HttpClientResponse response = restResponse.getResponse(); | ||
| if (response == null) { | ||
| // invoke failed, call another SC instance | ||
| if (!retry(requestContext, syncHandlerEx(countDownLatch, holder))) { |
There was a problem hiding this comment.
How about the service center doesn't send the response back.
Do we have timeout mechanism for CountDownLatch?
BTW, is it enough if we just retry once?
There was a problem hiding this comment.
httpClientRequest.setTimeout to control timeout.
if no response, then timeout and callback with new RestResponse(requestContext, null),that means response is null
retry just copy from old code, infact maybe no need to retry, because registerSchema failed means registerMicroservice failed, and will auto retry.
There was a problem hiding this comment.
If we don't need the retry here, we can consider to remove this part of code.
4 participants
No description provided.