[JAV-235]解决query/path参数的转码问题；以及body的编码问题 #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillemJiang
reviewed
Jul 27, 2017
| InputStream inputStream = (InputStream) body; | ||
|
|
||
| String contentType = request.getContentType(); | ||
| if (contentType != null && contentType.startsWith(MediaType.TEXT_PLAIN)) { |
There was a problem hiding this comment.
You can get the encoding information from the content-type , just like this "Content-Type: text/html; charset=utf-8" .
I don't think using the "UTF-8" without checking the charset is good idea. We can use the default setting as UTF-8, but when user specify the charset, we need to take it in the consideration.
There was a problem hiding this comment.
I add a TODO to fix this later. But we use a hard code now. Now UTF-8 is the correct one, because most URI encoding use UTF-8 and we use json as body, they are all UTF-8
There was a problem hiding this comment.
WillemJiang
requested changes
Jul 27, 2017
WillemJiang
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.