[JAV-280]1. init client and setup to avoid deadlock; 2. avoid NetUtil… #109
+31
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to block for a long time because of too many reverse host name lookup
wujimin
approved these changes
Aug 8, 2017
WillemJiang
reviewed
Aug 8, 2017
| } | ||
|
|
||
| private boolean deployClient() { | ||
| return HighwayClientManager.INSTANCE.getHighwayClient(true) != null && |
There was a problem hiding this comment.
是的。3种不同的transport。 不同的实现里面基本都是一样的过程。 有一定重复度比较正常。 如果放在一起，就变得不那么独立，也不是很好。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s to block for a long time because of too many reverse host name lookup