Skip to content

[JAV-286]add protect feature when call remote calls in bean initializ… #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2017
Merged

[JAV-286]add protect feature when call remote calls in bean initializ… #113

merged 3 commits into from
Aug 14, 2017

Conversation

liubao68
Copy link
Contributor

…ation

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.42% when pulling 2e69f2b on liubao68:call into 77b4718 on ServiceComb:master.

WillemJiang
WillemJiang reviewed Aug 11, 2017
View reviewed changes
core/src/main/java/io/servicecomb/core/SystemBootListener.java
@Component
public class SystemBootListener implements BootListener {

private static boolean ready = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value of boolean is false, so you don't need assign the value.

Copy link
Contributor Author

@liubao68 liubao68 Aug 14, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see many guidelines saying better to give a default value implicitly. e.g. some eclipse compiler and coverity tools. It's more readable and no side effects.

WillemJiang
WillemJiang reviewed Aug 11, 2017
View reviewed changes
core/src/test/java/io/servicecomb/core/TestSystemBootListener.java Outdated
import org.junit.Test;

/**
* Created by l00168639 on 2017/8/10.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the template for it.

WillemJiang
WillemJiang requested changes Aug 11, 2017
View reviewed changes
demo/demo-pojo/pojo-client/src/main/java/io/servicecomb/demo/pojo/client/BeanRpcTest.java Outdated
import org.springframework.stereotype.Component;

/**
* Created by l00168639 on 2017/8/10.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 85.426% when pulling e123d8d on liubao68:call into 77b4718 on ServiceComb:master.

@WillemJiang WillemJiang merged commit ebc3503 into apache:master Aug 14, 2017
@WillemJiang WillemJiang added this to the 0.2.0 milestone Aug 19, 2017
@liubao68 liubao68 deleted the call branch January 5, 2018 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillemJiang WillemJiang WillemJiang approved these changes

@wujimin wujimin Awaiting requested review from wujimin

@seanyinx seanyinx Awaiting requested review from seanyinx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@liubao68 @coveralls @WillemJiang