-
Notifications
You must be signed in to change notification settings - Fork 826
JAV-283 Unified servlet init #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… not return null, let's user know the error earlier
…serviceRegistry should init earlier
…vlet init, sevlet can not get transport reference
</param-value> | ||
</context-param> | ||
|
||
<!-- usage 1 equals usage 2 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these two cases are same, we don't need to keep the case 2 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document had not finished now, so remain the information here
after document finished, move the description to the document
} | ||
|
||
// web container did not did listen now. | ||
// so mock to listen, and then close. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you just want to test if the port is open for use. Spring should do it, Do you have to do it yourself ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if dynamic inject servlet, depend on if web container listened
but for embed web container, did not listen in this time, for unified the inject logic, we do listen and close in this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just put the "RestServletInjector.defaultInject(servletContext);" there instead of checking the port?
It's much simple, you don't need to check the port here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can not.
if serviceComb work with spring boot embed web container, and serviceComb use another port(that means use vertx rest transport), if this time
if we register our servlet, will cause embed web container failed
No description provided.