Skip to content

Conversation

wujimin
Copy link
Contributor

@wujimin wujimin commented Aug 12, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 85.368% when pulling ecd7fb9 on wujimin:unified-servlet-init into 77b4718 on ServiceComb:master.

</param-value>
</context-param>

<!-- usage 1 equals usage 2 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these two cases are same, we don't need to keep the case 2 here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document had not finished now, so remain the information here
after document finished, move the description to the document

}

// web container did not did listen now.
// so mock to listen, and then close.
Copy link
Member

@WillemJiang WillemJiang Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you just want to test if the port is open for use. Spring should do it, Do you have to do it yourself ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if dynamic inject servlet, depend on if web container listened
but for embed web container, did not listen in this time, for unified the inject logic, we do listen and close in this time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just put the "RestServletInjector.defaultInject(servletContext);" there instead of checking the port?
It's much simple, you don't need to check the port here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can not.
if serviceComb work with spring boot embed web container, and serviceComb use another port(that means use vertx rest transport), if this time
if we register our servlet, will cause embed web container failed

@WillemJiang WillemJiang merged commit 51e77fa into apache:master Aug 14, 2017
@WillemJiang WillemJiang added this to the 0.2.0 milestone Aug 19, 2017
@wujimin wujimin deleted the unified-servlet-init branch August 23, 2017 08:56
@wujimin wujimin changed the title Unified servlet init JAV-283 Unified servlet init Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants