JAV-286 Assert rpc invocation cannot start before sdk init #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 18, 2017 10:55
…ntrol this logic.
liubao68
approved these changes
Aug 18, 2017
WillemJiang
reviewed
Aug 18, 2017
|
|
||
| public void prepare() { | ||
| referenceConfig = CseContext.getInstance().getConsumerProviderManager().getReferenceConfig(microserviceName); | ||
| protected void prepare() { |
There was a problem hiding this comment.
It's not binary compatible change, it's better to keep the method signature there.
There was a problem hiding this comment.
prepare method was added yesterday
WillemJiang
approved these changes
Aug 18, 2017
|
|
||
| public void prepare() { | ||
| referenceConfig = CseContext.getInstance().getConsumerProviderManager().getReferenceConfig(microserviceName); | ||
| protected void prepare() { |
WillemJiang
changed the title
wujimin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old implementation had bugs:
1.we set ready in EventType.AFTER_REGISTER
and we suggest developers begin their logic by listen EventType.AFTER_REGISTER too
these two logic's order is undefined
2.invocationFactory is not the invoke entry, we have 3 entries:
a.Invoker
b.CseClientHttpRequest.createRequestMeta
c.InvokerUtils
if developers make remote call in invalid stage, sdk maybe throw exception before invocationFactory