[JAV-364]add more details message when laodbalance not configured in … #141
Conversation
…consumer chain. add thread id in console log.
|
Can this warning show up when the application starts and refuses to start instead of runtime warning? |
|
|
||
| public Transport getTransport() { | ||
| if (endpoint == null) { | ||
| throw new IllegalStateException("Endpoint is empty. Forget to configure \"loadbalance\" in consumer handler chain?"); |
There was a problem hiding this comment.
Can we change the message to "Endpoint is empty. Please configure "loadbalance" in the consumer handler chain."?
There was a problem hiding this comment.
I guess this exception should be detected at startup time and should not be thrown at run time. Validate the microservice.yaml file before the application starts.
There was a problem hiding this comment.
we don't know which handler is loadBalance
because cutomer can dev their own loadBalance
There was a problem hiding this comment.
Yes, we don't know at which handler will a developer to set the address, and they may not use 'loadbalance' and define a address resolver themself. So this message is a best guess and don't use please or throw an error at startup.
5 participants
…consumer chain. add thread id in console log.