JAV-354 Servlet rest signature #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 14, 2017 12:49
…ream, this make mock HttpServletRequest more easy.
…, this need copy request body bytes, please use it carefully
… reset inputstream
wujimin
requested review from
WillemJiang,
eric-lee-ltk,
liubao68 and
seanyinx
wujimin
force-pushed
the
servlet-rest-signature
branch
from
43fed52 to
2781f49
Compare
WillemJiang
approved these changes
Sep 16, 2017
liubao68
reviewed
Sep 18, 2017
| // bodyBytes maybe be null | ||
| void beforeSendRequest(Invocation invocation, HttpClientRequest clientRequest, Buffer requestBodyBuffer); | ||
|
|
||
| // if finished, then return a none null response |
There was a problem hiding this comment.
It's better to give a java doc comment. spell non null ? or a response that is not null
liubao68
approved these changes
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when server is servlet rest, then support inject client/server filter to transport.